[ShaderGraph][2022.1] Fix 1356725 - incorrect appearance of warning message in Node Settings #5672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This PR fixes https://fogbugz.unity3d.com/f/cases/1356725/
The behavior for the HelpBoxRow changed and this instance did not get updated. This change updates the one use (that I could find) that doesn't handle the label setup correctly. With this change, we match the "without" image in the bug report - i.e., the text is both in the correct color and the text wraps so that the whole message is viewable.
Fixed (labeled "without" in the bug report):
Broken (labeled "with" in the bug report):
Testing status
Manual testing according to the repro steps in the bug report. I could not find any other uses of HelpBoxRow with message type warning elsewhere in the code base, so, contrary to the claim in the bug, I could not make a node with an error (e.g., an invalid custom function node) generate a similar warning in Node Settings.
For when the checks inevitably get erased (due to resolving changelog conflicts):
PR ShaderGraph on trunk
Comments to reviewers
Notes for the reviewers you have assigned.